Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes namespace bindings of ValueReference when updating property in WFS-T 2.0.0 #705

Merged
merged 1 commit into from
Aug 17, 2016

Conversation

dstenger
Copy link
Contributor

@dstenger dstenger commented Jun 6, 2016

This fix targets the transaction functionality of WFS 2.0.0.

Previously, when a ValueReference was updated by an update transaction the namespace was not considered. Instead, the default namespace of the FeatureType was used.

For example (POST body of update request):

<wfs:Transaction xmlns:wfs="http://www.opengis.net/wfs/2.0" xmlns:gml="http://www.opengis.net/gml/3.2" service="WFS"
  version="2.0.0">
  <wfs:Update xmlns:ns30="http://www.deegree.org/app" typeName="ns30:ft">
    <wfs:Property>
      <wfs:ValueReference>gml:name[1]</wfs:ValueReference>
      <wfs:Value>Ce n&amp;apos;est pas Vieux-Port de Montr&amp;#xe9;al!</wfs:Value>
    </wfs:Property>
    <fes:Filter xmlns:fes="http://www.opengis.net/fes/2.0">
      <fes:ResourceId rid="ft_411196921" />
    </fes:Filter>
  </wfs:Update>
</wfs:Transaction>

In the current implementation of deegree the property app:name is updated instead of gml:name.

This fix introduces a determination of the namespace URI for properties. The so determined namespace is used to update the property then. If no namespace binding is given or it does not match any namespace URI, the previous behaviour is retained: The namespace of the FeatureType is used.

@dstenger dstenger added bug error issue and bug (fix) in progress labels Jun 6, 2016
@tfr42 tfr42 added this to the 3.4 milestone Jun 10, 2016
@tfr42 tfr42 changed the title Consider namespace bindings of ValueReference when updating property in WFS 2.0.0 Fixes namespace bindings of ValueReference when updating property in WFS-T 2.0.0 Aug 11, 2016
@copierrj copierrj merged commit 9ee4640 into deegree:master Aug 17, 2016
@lgoltz lgoltz deleted the updateOfGmlProperties-3501 branch December 8, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error issue and bug (fix)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants