Updated behaviour of replace transaction in WFS 2.0.0 #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when idGenMode useExisting was not activated, a replace transaction of the WFS 2.0.0 generated a new gml:id for the replaced feature (technically, a delete and insert operation is executed).
This is not conform to the specification as a replace transaction should replace an existing feature and not create a new one.
This behaviour was fixed by always activating the UseExisting option for replace transactions. This makes replacements of existing features possbile even if idGenMode useExisting is not activated.
When discussing this pull request, it has to be considered, that the current behaviour of deegree is modified. Now, a replace transaction with disabled UseExisting option uses the gml:id of the feature of the request instead of generating a new gml:id.
In addition, deegree now passes following test of the CITE WFS 2.0 test suite (Transactional CC) [1] when idGenMode useExisting is not activated:
[1] http://cite.opengeospatial.org/teamengine/