Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed exception of WFS if geometry operand is not a geometry property #719

Conversation

dstenger
Copy link
Contributor

@dstenger dstenger commented Jun 23, 2016

Previously, when a geometry operand was not a geometry property a NoApplicableCode exception was thrown.

Example request:

<wfs:GetFeature xmlns:wfs="http://www.opengis.net/wfs/2.0"
    count="10" service="WFS" startIndex="0" version="2.0.0">
    <wfs:Query xmlns:ns55="http://www.deegree.org/app" typeNames="ns55:gns_iceland">
        <fes:Filter xmlns:fes="http://www.opengis.net/fes/2.0">
            <fes:BBOX>
                <fes:ValueReference xmlns:tns="http://www.opengis.net/gml/3.2">tns:description</fes:ValueReference>
                <gml:Envelope xmlns:gml="http://www.opengis.net/gml/3.2"
                    srsName="urn:ogc:def:crs:EPSG::4326">
                    <gml:lowerCorner>62 -26</gml:lowerCorner>
                    <gml:upperCorner>67.11 -6</gml:upperCorner>
                </gml:Envelope>
            </fes:BBOX>
        </fes:Filter>
    </wfs:Query>
</wfs:GetFeature>

The FE 2.0.0 specification (OGC 09-026r1 and ISO 19143:2010(E)) states that an InvalidParameterValue exception is expected (Chapter 8.3 Exceptions, page 43):

In the event that the fes:ValueReference element contains a reference to a value of a 
known resource type but that value if not defined for the resource type being queried, 
the service shall raise an InvalidParameterValue (as given in OGC 06-121r3, Table 25) 
exception.

This fix updates the exception code to InvalidParameterValue for the pictured case.

Following test of the OGC CITE WFS 2.0 test suite [1] is now passed due to this fix:

  • "invalid Geometry Operand"

[1] http://cite.opengeospatial.org/teamengine/

@dstenger dstenger added in progress bug error issue and bug (fix) labels Jun 23, 2016
@tfr42 tfr42 added this to the 3.4 milestone Jul 7, 2016
@copierrj copierrj merged commit 6f1d633 into deegree:master Aug 17, 2016
@lgoltz lgoltz deleted the exceptionCodeFilterWithInvalidGeometryProperty-3579 branch December 8, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error issue and bug (fix)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants