-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced RemoteWMS Layer to use XSLT files for GetFeatureInfo requests #722
Merged
tfr42
merged 10 commits into
deegree:main
from
lat-lon:transformationOfRemoteWmsGFIResponse-189
May 14, 2022
Merged
Enhanced RemoteWMS Layer to use XSLT files for GetFeatureInfo requests #722
tfr42
merged 10 commits into
deegree:main
from
lat-lon:transformationOfRemoteWmsGFIResponse-189
May 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re a xslt script transforming get feature info response from remote wms
…om public method, extracted interface
…tionOfRemoteWmsGFIResponse-189
…tionOfRemoteWmsGFIResponse-189
…moteWmsGFIResponse-189
stephanr
reviewed
May 13, 2022
@Override | ||
public FeatureCollection parseAsFeatureCollection( InputStream inputStream, String csvLayerNames ) | ||
throws XMLStreamException { | ||
XMLStreamReader xmlReader = XML_FACTORY.createXMLStreamReader( inputStream ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a remark, we have a security optimized way of getting a safe at https://github.com/deegree/deegree3/blob/master/deegree-core/deegree-core-commons/src/main/java/org/deegree/commons/xml/stax/XMLInputFactoryUtils.java#L60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
enhancement or improvement
ready
schema change
change to deegree configuration files
WMS
deegree Web Map Service
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when GetFeatureInfo was requested on a RemoteWMS Layer, a default parser for the returned XML of the remote service was used. As the returned XML often has different structures depending on the implementation of the remote service, the default parser already considers different structures (e.g. ESRI has its own structure) but it is, of course, limited to the in deegree implemented cases.
This pull request introduces the possibility to set a XSLT file in the RemoteWMS Layer which is used to configure the parser for the GFI response of the remote service. By that, deegree users can now configure the parser making it possible to use GFI responses of remote services which cannot be parsed by the default parser or control the structure of the GML.
The element
is used to activate a XSLT file for GetFeatureInfo requests to a remote layer.
The target GML version must also be configured.
Full configuration example of the new option: