Enhanced ReferenceResolvingException to be multilingual #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanr
added
the
TMC discussion
tfr42
requested changes
Dec 6, 2019
|
The TMC is (in principle) in favor of i18n efforts. However: if we are going to endorse this we would expect that (eventually) every string is translated. Not just this one. |
|
The TMC re-evaluated the need for i18n within deegree. Although we are by no means against i18n in general we would like it to be a all or nothing solution. Translating just a single error message into another language doesn't seem to be the right approach. |
tfr42
added
invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the ReferenceResolvingException was a hard coded message in english. With this pull requests a german message was provided by using i18n messages from ResourceBundle.