Improved support of UTF-8/ASCII in the SQLFeatureStore #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoltz
deleted the
translateUnicodeToAsciiInFeatureStoreCOnfigWriter-3.4-4166
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes two aspects of the character encoding in the SQLFeatureStore configuration.
The Feature Store Wizard fails if the application schema contains non 7-bitASCII characters. The created created SQLFeatureStore configuration contains the special chars in the mapping, which causes a NPE during parsing. This is fixed from two sides: First during the creation of the schema the name of columns and tables is translated from UTF-8 to ASCII. Therefor the project Junidecode [1] was forked [2], and a release [3] with a new buildjob [4] created. Second the ANTLR lexer rule for the identifier was enhanced to support UTF-8 as well. This allows user configuring deegree to use special chars from UTF-8.
Fix for #757
[1] https://github.com/gcardone/junidecode
[2] https://github.com/deegree/junidecode
[3] http://repo.deegree.org/content/repositories/releases/org/deegree/junidecode/0.2/junidecode-0.2.jar
[4] http://buildserver.deegree.org/view/misc/job/junidecode