Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startIndex for SQL featureStore (queryByOperatorFilter) #832

Closed
wants to merge 1 commit into from

Conversation

RomainWieser
Copy link

Pass the startIndex into SQL with OFFSET keyword and count whith LIMIT.

Not tested with other featureStore...

@tfr42 tfr42 added this to the 3.4 milestone May 29, 2017
@tfr42 tfr42 added the bug error issue and bug (fix) label May 29, 2017
@tfr42 tfr42 added needs discussion requires discussion with contributor under review PR under review by TMC member labels Oct 6, 2017
@stephanr stephanr added enhancement enhancement or improvement and removed bug error issue and bug (fix) labels Oct 6, 2017
@copierrj
Copy link
Member

copierrj commented Oct 6, 2017

Thank you for your pull request. Unfortunately your suggested improvement has a major drawback: it only works correctly for PostgreSQL.

In order to support other databases, the deegree code contains different implementations of a concept called SQLDialect (see module: deegree-core-sqldialect).

For this improvement to be accepted by the deegree project it is necessary to rework the code and have it use the sql dialect infrastructure instead of doing stuff directly in SQL.

Feel free to ask if you have any questions.

@tfr42 tfr42 removed this from the 3.4 milestone Nov 6, 2017
@tfr42 tfr42 added the stuck stuck PR label Nov 6, 2017
@tfr42 tfr42 added the contributions welcome asking for contribution (time and money sponsor) label Feb 16, 2018
@tfr42 tfr42 added this to the 3.4 milestone Feb 16, 2018
@tfr42 tfr42 modified the milestones: 3.4, 3.4.1 Apr 6, 2018
@tfr42 tfr42 modified the milestones: 3.4.1, 3.5 Jun 18, 2018
@tfr42 tfr42 modified the milestones: 3.5, Backlog Jun 14, 2019
@tfr42 tfr42 added the CI failing CI build job fails label Feb 4, 2022
@tfr42 tfr42 added the needs rebase PR is not up to date and needs rebase label May 16, 2022
@tfr42 tfr42 changed the title startIndex fix for SQL featureStore (queryByOperatorFilter) Fix startIndex for SQL featureStore (queryByOperatorFilter) Dec 9, 2022
@tfr42 tfr42 added duplicate and removed needs discussion requires discussion with contributor needs rebase PR is not up to date and needs rebase contributions welcome asking for contribution (time and money sponsor) under review PR under review by TMC member labels Nov 30, 2023
@stephanr
Copy link
Member

This is a duplicate of #1128 so the TMC decided to close this one.

@stephanr stephanr closed this Nov 30, 2023
@tfr42 tfr42 removed this from the Backlog milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI failing CI build job fails duplicate enhancement enhancement or improvement stuck stuck PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants