Fixed unexpected GetMap responses from remote WMS #872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring the WMS [1] as a remote service leads to unexpected (empty) GetMap responses. in the theme configuration the layers are merged into one Theme:
The service contains layers
Requesting the layer
ALK
with styledefault
leads toThe reason for this is the following method:
deegree3/deegree-core/deegree-core-layer/src/main/java/org/deegree/layer/AbstractLayer.java
Lines 96 to 103 in 8c9568a
In case 2. (no styles are available cause the inheritance is not considered) this results in true, in case 1. to false.
This fix overwrites the method isStyleApplicable in RemoteWMSLayer to return true in case the default layer is requested. This makes the handling of a default style mandatory for the remote WMS layer. This should be ok as described in WMS 1.3.0 spec:
[1] www.wms.nrw.de/geobasis/wms_nw_alkis?service=WMS&request=GetCapabilities