-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Bump dependency versions #916
Conversation
Especially switches everything to log4j2, since 1.x reached EOL in 2015.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. May it be possible to split the commits for changing travis-ci config, log4j upgrade and batik update into separate PR?
Sure, I can do that in the next days. |
In the voice chat we discussed whether we have an advantage in replacing the generic SLF4J API with a concrete implementation of log4j2. Here we have come to the point that if there is no reason (such as peroformance problems or similar) we would prefer to keep SLF4J. |
Some arguments to use log4j2 over slf4j: https://logging.apache.org/log4j/2.0/faq.html#api-tradeoffs Ultimately I really have no preference, but log4j2 seems to offer the most flexibility. You can easily use logback via the log4j2 API, but I'm not sure the other way round. |
The TMC decided that we are not prepared to switch to a different logging api at this point in time. Are you able to prepare a PR without this change? |
I'll try that when I find the time. Unfortunately that has a couple of consequences:
|
Unfortunately, the previous fix did not fix all (travis) issues. I've added deegree/deegree-maven-plugin#10 to fix the test related issues. I guess me locally relying on having the proprietary libraries available did not produce those issues before. This does not seem to fix all issues related to generated I've also added skipping the As a last point, I'm sorry to say, since I'm just doing this in my spare time, I'm not really willing to rewrite everything back to using Let me know if you want me to keep going at this, if you want to drop/close it, feel free to do so (please let me know by mail/comment, I may not be available at the next IRC chat). |
This bumps lots of dependency versions, especially switches to log4j2 since log4j 1.x was EOLed in 2015.
Once deegree/deegree-maven-plugin#9 is merged and 2.0.1 is released, I can upgrade the plugin version here and hopefully have a green travis build (once the geotools repo is added to the nexus proxy as I commented in #903).