Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AutoTypings to monaco editor #183

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

FreePhoenix888
Copy link
Member

No description provided.

@FreePhoenix888
Copy link
Member Author

If I use import on top level or dynamic import on any level I get autocompletion
image
image
image
But if I use require parameter of function that we always use for handlers - I do not get autocompletion
image

@FreePhoenix888 FreePhoenix888 self-assigned this Jul 10, 2023
@FreePhoenix888 FreePhoenix888 changed the title Add AutoTypings to handleEditorDidMount Add AutoTypings to monaco editor Jul 10, 2023
@FreePhoenix888
Copy link
Member Author

If we transfer js-docker-isolation-prodiver to ESNext, can we safely use await import (dynamic import) and therefore be able to have autocompletion in the monaco editor? Or will we still have to pass the function for import? Even if yes, we can always make our own fork of the monaco-editor-auto-typings package and change it for ourselves (but this will require more resources)

In addition, another question arises: what if the handler is not js-docker, but plv8?

@Konard , @ivansglazunov

@FreePhoenix888 FreePhoenix888 linked an issue Jul 10, 2023 that may be closed by this pull request
@FreePhoenix888
Copy link
Member Author

lukasbach/monaco-editor-auto-typings#36 has fixed autocompletion for scroped packages

@FreePhoenix888
Copy link
Member Author

await import is working but @Konard tells me to use await deep.import 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

feature: add autocompletion when importing libraries
1 participant