Skip to content

Commit

Permalink
Jonatan/mon 2641 remove launchdarkly (#384)
Browse files Browse the repository at this point in the history
  • Loading branch information
JKL98ISR authored Nov 28, 2024
1 parent 8f99af7 commit 366826c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion backend/deepchecks_monitoring/ee/features_control_cloud.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def model_assignment(self) -> bool:

@property
def signup_enabled(self) -> bool:
return True
return False

@property
def onboarding_enabled(self) -> bool:
Expand Down
1 change: 1 addition & 0 deletions backend/deepchecks_monitoring/features_control.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
class FeaturesSchema(BaseModel):
"""Schema to be returned to the client for the features control."""

signup_enabled: bool
slack_enabled: bool
rows_per_minute: int
onboarding_enabled: bool
Expand Down
3 changes: 0 additions & 3 deletions backend/deepchecks_monitoring/logic/data_ingestion.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import asyncio
import copy
import json
import logging
import typing as t

import asyncpg.exceptions
Expand Down Expand Up @@ -346,8 +345,6 @@ def __init__(
self.resources_provider: ResourcesProvider = resources_provider
self.logger = logger or configure_logger(name="data-ingestion")
self.use_kafka = self.resources_provider.kafka_settings.kafka_host is not None
if self.use_kafka:
logging.getLogger("aiokafka.cluster").setLevel(logging.DEBUG)

async def _send_with_retry(
self,
Expand Down
4 changes: 4 additions & 0 deletions backend/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ def features_control_mock(settings):
class TestsFeaturesControl(CloudFeaturesControl):
"""Mocked features control class for tests, replacing launchdarkly usage."""

@property
def signup_enabled(self) -> bool:
return True

@property
def rows_per_minute(self) -> int:
"""Maximum number of rows per minute allowed for organization."""
Expand Down

0 comments on commit 366826c

Please sign in to comment.