fix-exception-running-task-did-not-find-monitor-with-the-id (#371)

deepchecks · Oct 1, 2024 · 9cabc75 · 9cabc75
1 parent 433fb79
commit 9cabc75
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/backend/deepchecks_monitoring/bgtasks/alert_task.py b/backend/deepchecks_monitoring/bgtasks/alert_task.py
@@ -125,7 +125,8 @@ async def execute_monitor(
     ))
 
     if monitor is None:
-        raise ValueError(f'Did not find monitor with the id {monitor_id}')
+        logger.info('Did not find monitor with the id: %s', monitor_id)
+        return []
 
     check = monitor.check
     alert_rules = monitor.alert_rules

diff --git a/backend/deepchecks_monitoring/bgtasks/tasks_queuer.py b/backend/deepchecks_monitoring/bgtasks/tasks_queuer.py
@@ -28,7 +28,7 @@
 from deepchecks_monitoring.bgtasks.mixpanel_system_state_event import MixpanelSystemStateEvent
 from deepchecks_monitoring.bgtasks.model_data_ingestion_alerter import ModelDataIngestionAlerter
 from deepchecks_monitoring.bgtasks.model_version_cache_invalidation import ModelVersionCacheInvalidation
-from deepchecks_monitoring.bgtasks.model_version_topic_delete import ModelVersionTopicDeletionWorker
+# from deepchecks_monitoring.bgtasks.model_version_topic_delete import ModelVersionTopicDeletionWorker
 from deepchecks_monitoring.config import DatabaseSettings, RedisSettings
 from deepchecks_monitoring.logic.keys import GLOBAL_TASK_QUEUE
 from deepchecks_monitoring.monitoring_utils import configure_logger
@@ -201,7 +201,7 @@ async def main():
                 ee.utils.telemetry.collect_telemetry(tasks_queuer.TasksQueuer)
 
         workers = [
-            ModelVersionTopicDeletionWorker,
+            # ModelVersionTopicDeletionWorker,
             ModelVersionCacheInvalidation,
             ModelDataIngestionAlerter,
             DeleteDbTableTask,