Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add environment files for dependencies installation. Closes #163 #169

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Add environment files for dependencies installation. Closes #163 #169

merged 2 commits into from
Mar 18, 2020

Conversation

umesh-timalsina
Copy link
Contributor

Closes #163

brollb
brollb reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@brollb brollb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work. However, if the files are identical, they can be merged into a single environment.yml file. Otherwise, the server shouldn't need pillow or dill.

@umesh-timalsina
Copy link
Contributor Author

umesh-timalsina commented Mar 18, 2020 •
edited
Loading

I have removed pillow and dill from the requirements of the server.

@brollb brollb merged commit 0d413d9 into master Mar 18, 2020
@brollb brollb deleted the 163-deepforge-extension-dependencies branch March 18, 2020 16:45
@umesh-timalsina umesh-timalsina mentioned this pull request Mar 18, 2020
Closed
@umesh-timalsina umesh-timalsina mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brollb brollb brollb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update deepforge-extension.json to include python dependencies
2 participants
@umesh-timalsina @brollb