Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use available streams support functions in pipeline execution #1777

Closed
11 tasks done
umesh-timalsina opened this issue Jul 16, 2020 · 0 comments
Closed
11 tasks done

Use available streams support functions in pipeline execution #1777

umesh-timalsina opened this issue Jul 16, 2020 · 0 comments
Assignees
@umesh-timalsina
Labels
enhancement pipeline execution
Milestone
v2.4.0

Comments

@umesh-timalsina
Copy link
Contributor

umesh-timalsina commented Jul 16, 2020 •
edited
Loading

Stemming from #1690, Depends on #1703
The most direct way to fix this would probably be to update the storage adapter API so getFile returns a ReadableStream rather than a Buffer. Similarly, putFile should probably accept a ReadableStream for the file input (or perhaps adding support for a ReadableStream but not requiring it).
Taking a quick look at the codebase, the following files would need to be updated:

Originally posted by @brollb in #1690 (comment)
@umesh-timalsina umesh-timalsina self-assigned this Jul 16, 2020
@umesh-timalsina umesh-timalsina added this to the v2.4.0 milestone Jul 20, 2020
umesh-timalsina added a commit that referenced this issue Jul 28, 2020
@umesh-timalsina
Use stream functions in pipelines. (Closes #1777)
e27bd6b 
This commit adds stream support function added in #1702 for pipeline
execution as well as Interactive Compute router. build job utils
now uses webgme-engine module in webgme/node_modules. This will
add the support for streams in blobclient.
@brollb brollb closed this as completed in ba1ec5b Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umesh-timalsina umesh-timalsina

Labels
enhancement pipeline execution
Projects
None yet
Milestone
v2.4.0
Development

No branches or pull requests
1 participant
@umesh-timalsina