Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NodeJS/browser exec env detection. Fixes #1212 #1213

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

brollb
Copy link
Contributor

@brollb brollb commented Mar 11, 2019

Check the environment using the isBrowser flag from requirejs instead of checking for WebGMEGlobal as this can exist in the automated tests.

@brollb brollb merged commit abbbf0e into master Mar 11, 2019
@brollb brollb deleted the 1212-detect-nodejs-env-in-tests branch March 11, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant