Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle is_final and endpointing together with utterance end #264

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

DamienDeepgram
Copy link
Contributor

Proposed changes

This is an improved version to make it easier to understand the docs here

Users tend to not understand how to handle these things and our samples do not include how it works

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

@lukeocodes
Copy link
Contributor

hey bud, what's this for? might be worth making this a separate example file. don't be afraid to make as many examples as you want, just name them appropriately

@DamienDeepgram
Copy link
Contributor Author

DamienDeepgram commented Apr 17, 2024

This is to properly handle the websocket messages for endpointing, utterance end and interim results

Here is the same for the Python SDK example

deepgram/deepgram-python-sdk#364

@lukeocodes lukeocodes changed the base branch from main to release/3.x.x-20240425 April 27, 2024 10:48
@lukeocodes lukeocodes merged commit 9b3358c into release/3.x.x-20240425 Apr 27, 2024
1 check passed
@lukeocodes lukeocodes deleted the is-final-handling branch April 27, 2024 10:48
lukeocodes added a commit that referenced this pull request Apr 27, 2024
* feat: add _experimentalCustomFetch config to override fetch (#245)

* feat: allow to provide custom fetch method to AbstractRestfulClient

* fix: allow to provide both fetch and fetch options

* refactor: init custom fetch in resolveFetch

* rename `customFetch` to `_experimentalCustomFetch`

i want to avoid taking any new namespaces while i think about the best way to do this

* use `_experimentalCustomFetch` instead of `customFetch` for fetch override

* test: added custom fetch test

---------

Co-authored-by: Luke Oliff <luke@lukeoliff.com>

* chore: Bump es5-ext from 0.10.62 to 0.10.64 (#250)

Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64.
- [Release notes](https://github.com/medikoo/es5-ext/releases)
- [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md)
- [Commits](medikoo/es5-ext@v0.10.62...v0.10.64)

---
updated-dependencies:
- dependency-name: es5-ext
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: add get auth token details method to manage client (#262)

* chore: edit example for is_final and endpointing together with utterance end (#264)

* fix: add missing expiration_date to CreateProjectKeyResponse (#265)

* fix: update user agent to include JS or node (#269)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Bartosz Jarocki <bartosz.jarocki@hey.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: DamienDeepgram <138720050+DamienDeepgram@users.noreply.github.com>
Co-authored-by: Lachlan Donald <lachlan@ljd.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants