Skip to content

Conversation

@pcgeek86
Copy link
Contributor

Proposed changes

Adds a default TTL to the model downloader job.
This will remove completed pods so that they don't retain their hold on the Deepgram PersistentVolumeClaim (PVC) resource.
Before this change, running a Helm uninstall command could hang because the Completed job would still have a handle to the Amazon EFS PVC.

Types of changes

What types of changes does your code introduce to the Deepgram self-hosted resources?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have tested my changes in my local self-hosted environment
    • Please describe your testing setup and methodology here
  • I have added necessary documentation (if appropriate)

@pcgeek86 pcgeek86 requested review from a team and therealevanhenry as code owners October 14, 2025 01:35
@jkroll-deepgram
Copy link
Contributor

Awesome, LGTM! To pass CI, please add a line to the changelog describing what you added or changed: https://github.com/deepgram/self-hosted-resources/blob/main/charts/deepgram-self-hosted/CHANGELOG.md

@jkroll-deepgram
Copy link
Contributor

You'll also need to run helm-docs to update the readme and document the new param

@pcgeek86
Copy link
Contributor Author

You'll also need to run helm-docs to update the readme and document the new param

Hmmm, I installed it and ran it. It spits out a bunch of Markdown files.

Are there any specific parameters I need to use on helm docs, or run it in a particular directory context? @jkroll-deepgram

@jkroll-deepgram
Copy link
Contributor

@pcgeek86, running the helm-docs command from the top-level repo should update the values in charts/deepgram-self-hosted/README.md to reflect any changes to values you made (in this case, to add ttlSecondsAfterFinished)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants