Skip to content

Commit

Permalink
Stop requesting column statistics for preview columns (#4828)
Browse files Browse the repository at this point in the history
Will be reverted as part of #188

Fixes #4825
  • Loading branch information
niloc132 authored and stanbrub committed Nov 15, 2023
1 parent 6b5d67e commit 16b3461
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1435,6 +1435,11 @@ public Promise<JsPartitionedTable> partitionBy(Object keys, @JsOptional Boolean
*/
@JsMethod
public Promise<JsColumnStatistics> getColumnStatistics(Column column) {
if (column.getDescription() != null && column.getDescription().startsWith("Preview of type")) {
// TODO (deephaven-core#188) Remove this workaround when we don't preview columns until just before
// subscription
return Promise.reject("Can't produce column statistics for preview column");
}
List<Runnable> toRelease = new ArrayList<>();
return workerConnection.newState((c, state, metadata) -> {
ColumnStatisticsRequest req = new ColumnStatisticsRequest();
Expand Down

0 comments on commit 16b3461

Please sign in to comment.