Reference arrow-java issue for List of Union

deephaven · Feb 8, 2025 · 36ce6ae · 36ce6ae
1 parent 48b5884
commit 36ce6ae
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/cpp-client/deephaven/dhclient/include/public/deephaven/client/utility/internal_types.h b/cpp-client/deephaven/dhclient/include/public/deephaven/client/utility/internal_types.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016-2024 Deephaven Data Labs and Patent Pending
+ * Copyright (c) 2016-2025 Deephaven Data Labs and Patent Pending
  */
 #pragma once
 

diff --git a/cpp-client/deephaven/dhclient/src/arrowutil/arrow_column_source.cc b/cpp-client/deephaven/dhclient/src/arrowutil/arrow_column_source.cc
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016-2024 Deephaven Data Labs and Patent Pending
+ * Copyright (c) 2016-2025 Deephaven Data Labs and Patent Pending
  */
 #include "deephaven/client/arrowutil/arrow_column_source.h"
 #include "deephaven/client/utility/arrow_util.h"

diff --git a/cpp-client/deephaven/tests/src/time_unit_test.cc b/cpp-client/deephaven/tests/src/time_unit_test.cc
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016-2024 Deephaven Data Labs and Patent Pending
+ * Copyright (c) 2016-2025 Deephaven Data Labs and Patent Pending
  */
 #include <iostream>
 #include "deephaven/third_party/catch.hpp"

diff --git a/server/jetty/src/test/java/io/deephaven/server/jetty/JettyBarrageChunkFactoryTest.java b/server/jetty/src/test/java/io/deephaven/server/jetty/JettyBarrageChunkFactoryTest.java
@@ -967,10 +967,16 @@ public void testMultiUnion() throws Exception {
 
             @Override
             public void runTest() throws Exception {
-                // note that dense union requires a separate null column if you want null values
+                // TODO: revisit this test once https://github.com/apache/arrow-java/issues/399 is fixed
+                // since arrow-java has significant bugs w.r.t. Lists of Unions
                 runTest(TestWrapMode.NONE, TestNullMode.NONE);
-                // for (TestArrayMode wrapMode : TestArrayMode.values()) {
-                // runTest(TestNullMode.NONE, wrapMode);
+                // for (TestWrapMode wrapMode : TestWrapMode.values()) {
+                // if (wrapMode == TestWrapMode.FIXED_ARRAY || wrapMode == TestWrapMode.FIXED_VECTOR) {
+                // // it appears that VectorSchemaRoot#create loses the inner dense union types; another bug
+                // continue;
+                // }
+                // // note that dense union requires a separate null column if you want null values
+                // runTest(wrapMode, TestNullMode.NONE);
                 // }
             }