review feedback

deephaven · Dec 28, 2021 · 86b6dd3 · 86b6dd3
1 parent a96c67e
commit 86b6dd3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/buildSrc/src/main/groovy/Classpaths.groovy b/buildSrc/src/main/groovy/Classpaths.groovy
@@ -51,7 +51,7 @@ class Classpaths {
  static final String ARROW_VERSION = '5.0.0'
 
  static final String SLF4J_GROUP = 'org.slf4j'
- static final String SLF4J_VERSION = '2.0.0-alpha4'
+ static final String SLF4J_VERSION = '2.0.0-alpha5'
 
  static final String FLATBUFFER_GROUP = 'com.google.flatbuffers'
  static final String FLATBUFFER_NAME = 'flatbuffers-java'
@@ -76,7 +76,7 @@ class Classpaths {
 
  static final String LOGBACK_GROUP = 'ch.qos.logback'
  static final String LOGBACK_NAME = 'logback-classic'
- static final String LOGBACK_VERSION = '1.3.0-alpha10'
+ static final String LOGBACK_VERSION = '1.3.0-alpha12'
 
  static final String GROOVY_GROUP = 'org.codehaus.groovy'
  static final String GROOVY_VERSION = '3.0.9'

diff --git a/server/jetty/README.md b/server/jetty/README.md
@@ -27,8 +27,8 @@ be sure to first set `PYTHON_CONFIGURE_OPTS="--enabled-shared"`.
  $ export DEEPHAVEN_VERSION=0.8.0 # this should match the current version of your git repo
 
  $ cd py/jpy
- $ JAVA_HOME=/path/to/your/java/home # Customize this to fit your computer
- $ python setup.py bdist_wheel
+ $ export JAVA_HOME=/path/to/your/java/home # Customize this to fit your computer
+  $ python setup.py bdist_wheel
  $ pip install dist/deephaven_jpy-0.8.0-cp39-cp39-linux_x86_64.whl # This will vary by version/platform
  $ cd -
 

diff --git a/server/src/test/java/io/deephaven/server/appmode/ApplicationTest.java b/server/src/test/java/io/deephaven/server/appmode/ApplicationTest.java
@@ -54,7 +54,7 @@ public void app01() throws IOException {
  }
 
  @Test
- @Ignore("python test needs to run in a container")
+ @Ignore("TODO: deephaven-core#1741 python test needs to run in a container")
  public void app02() throws IOException, InterruptedException, TimeoutException {
  session = new PythonDeephavenSession(null, false, false);
  ApplicationState app = ApplicationFactory.create(ApplicationConfigs.testAppDir(), ApplicationConfigs.app02(),