Skip to content

Commit

Permalink
fix(cppclient): Update versions and change build type (#5721)
Browse files Browse the repository at this point in the history
For Windows build:
* Update protobuf to 4.25.1
* Update vcpkg itself to current SHA
* Change README.md so that user builds with type `RelWithDebInfo`
  • Loading branch information
kosak authored Jul 4, 2024
1 parent 0b28f11 commit 99b9c3d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cpp-client/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ Notes

9. Now configure the build for Deephaven Core:
```
cmake -B build -S . -DCMAKE_TOOLCHAIN_FILE=%VCPKG_ROOT%/scripts/buildsystems/vcpkg.cmake -DCMAKE_INSTALL_PREFIX=%HOMEDRIVE%%HOMEPATH%/dhinstall -DX_VCPKG_APPLOCAL_DEPS_INSTALL=ON
cmake -B build -S . -DCMAKE_TOOLCHAIN_FILE=%VCPKG_ROOT%/scripts/buildsystems/vcpkg.cmake -DCMAKE_INSTALL_PREFIX=%HOMEDRIVE%%HOMEPATH%/dhinstall -DX_VCPKG_APPLOCAL_DEPS_INSTALL=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo
```

10. Finally, build and install Deephaven Core:
Expand Down
2 changes: 1 addition & 1 deletion cpp-client/deephaven/vcpkg-configuration.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"default-registry": {
"kind": "git",
"baseline": "0dc005fb66801c8a8266e81bd2cedb4d5501f30e",
"baseline": "2444315f12ac0151ebcb8b28ba7cb132927f285d",
"repository": "https://github.com/microsoft/vcpkg"
},
"registries": [
Expand Down
2 changes: 1 addition & 1 deletion cpp-client/deephaven/vcpkg.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@

"overrides": [
{ "name": "arrow", "version": "13.0.0#1" },
{ "name": "protobuf", "version": "3.21.2" }
{ "name": "protobuf", "version": "4.25.1" }
]
}

0 comments on commit 99b9c3d

Please sign in to comment.