Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catPlot freezes up when using language native arrays #1560

Open
jakemulf opened this issue Nov 11, 2021 · 4 comments
Open

catPlot freezes up when using language native arrays #1560

jakemulf opened this issue Nov 11, 2021 · 4 comments
Labels
2023_noMilestone bug Something isn't working triage
Milestone

Comments

@jakemulf
Copy link
Contributor

jakemulf commented Nov 11, 2021

Description

The following Python code generates a simple category plot

from deephaven import Plot
from deephaven.TableTools import newTable, intCol, stringCol
source = newTable(
    stringCol("Categories", "A", "B", "C"),
    intCol("Values", 1, 3, 5)
)
result = Plot.catPlot("Categories Plot", source, "Categories", "Values")\
    .chartTitle("Categories And Values")\
    .show()

Our docs suggest that you can use native language arrays instead of Deephaven tables, so the following Python code should do the same thing. However it instead freezes up with no results

from deephaven import Plot
from numpy import array
categories = array(["A", "B", "C"], dtype=object)
values = array([1, 3, 5])
result = Plot.catPlot("Categories Plot", categories, values)\
    .chartTitle("Categories And Values")\
    .show()

This happens in Groovy as well, and for piePlot

Steps to reproduce

Described above

Expected results

Both code snippets should run with the same results

Actual results

The code snippet that uses arrays freezes up

Versions

  • Deephaven: latest
  • OS: OSX
  • Browser: Chrome
  • Docker: 20.10.8, build 3967b7d
@jakemulf jakemulf added bug Something isn't working triage labels Nov 11, 2021
@niloc132
Copy link
Member

This use case isn't supported in DHE either, though it should error out better than this. @mofojed is this a UI bug, or did the server stop sending "hey part of this figure doesnt make sense" errors?

@jakemulf
Copy link
Contributor Author

Screen Shot 2021-11-12 at 11 32 33 AM

I don't see any errors in the server logs, and this is what the UI looks like

@jakemulf
Copy link
Contributor Author

If this isn't a use case we plan to support I'll make sure to remove it from the docs

@mofojed
Copy link
Member

mofojed commented Nov 12, 2021

There are errors in the browser logs (you can attach the UI logs by going to Export Logs on the right menu)

2021-11-12-113520_support_logs.zip

The UI never receives a request failed event, but there is a stack trace in the log from the API @niloc132

dh-core.js:21195 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getTableId')
    at Object.$tableForSeries (dh-core.js:21195)
    at JsFigure$9methodref$tableForSeries$Type.apply_144 [as apply_2] (dh-core.js:21443)
    at Object.lambda$3_5 (dh-core.js:35173)
    at Collectors$lambda$3$Type.accept_76 [as accept_0] (dh-core.js:35413)
    at Object.lambda$4_6 (dh-core.js:36231)
    at StreamImpl$lambda$4$Type.apply_214 [as apply_4] (dh-core.js:36640)
    at Object.lambda$5_7 (dh-core.js:36237)
    at StreamImpl$lambda$5$Type.accept_95 [as accept] (dh-core.js:36651)
    at Object.$lambda$0_19 (dh-core.js:36490)
    at StreamImpl$FilterSpliterator$lambda$0$Type.accept_89 [as accept] (dh-core.js:36518)
    at Object.$lambda$0_19 (dh-core.js:36490)
    at StreamImpl$FilterSpliterator$lambda$0$Type.accept_89 [as accept] (dh-core.js:36518)
    at Object.$consume (dh-core.js:34158)
    at Spliterators$ArraySpliterator.consume (dh-core.js:34168)
    at Object.$tryAdvance_2 (dh-core.js:34128)
    at Spliterators$ArraySpliterator.tryAdvance_2 [as tryAdvance] (dh-core.js:34176)
    at StreamImpl$1.tryAdvance_17 [as tryAdvance] (dh-core.js:36295)
    at StreamImpl$FilterSpliterator.tryAdvance_21 [as tryAdvance] (dh-core.js:36504)
    at StreamImpl$FilterSpliterator.tryAdvance_21 [as tryAdvance] (dh-core.js:36504)
    at Object.$forEachRemaining_5 (dh-core.js:33910)
    at StreamImpl$FilterSpliterator.forEachRemaining_19 [as forEachRemaining] (dh-core.js:34058)
    at Object.$reduce (dh-core.js:36198)
    at Object.$collect_1 (dh-core.js:36104)
    at Object.$updateSubscriptions (dh-core.js:21220)
    at Function.run_34 (dh-core.js:21370)
    at lambda (dh-core.js:148)
    at Function.onInvoke_158 (dh-core.js:23667)
    at lambda (dh-core.js:148)

mofojed pushed a commit that referenced this issue Oct 24, 2023
# [0.50.0](deephaven/web-client-ui@v0.49.1...v0.50.0) (2023-10-13)

### Bug Fixes

* Change display of rollup key columns from null to empty string ([#1563](deephaven/web-client-ui#1563)) ([327bcb6](deephaven/web-client-ui@327bcb6)), closes [#1483](deephaven/web-client-ui#1483)
* Disabled failing e2e test ([#1554](deephaven/web-client-ui#1554)) ([49723ec](deephaven/web-client-ui@49723ec)), closes [#1553](deephaven/web-client-ui#1553)
* Formatting Rule Doesn't use default set by user ([#1547](deephaven/web-client-ui#1547)) ([ce51229](deephaven/web-client-ui@ce51229))
* Handle deletion of unsaved copied file in NotebookPanel ([#1557](deephaven/web-client-ui#1557)) ([4021aac](deephaven/web-client-ui@4021aac)), closes [#1359](deephaven/web-client-ui#1359)
* Prompt for resetting layout ([#1552](deephaven/web-client-ui#1552)) ([a273e64](deephaven/web-client-ui@a273e64)), closes [#1250](deephaven/web-client-ui#1250)


* CSS based loading spinner (#1532) ([f06fbb0](deephaven/web-client-ui@f06fbb0)), closes [#1532](deephaven/web-client-ui#1532) [#1531](deephaven/web-client-ui#1531)

### Features

* Add copy/rename/delete options to notebook overflow menu ([#1551](deephaven/web-client-ui#1551)) ([4441109](deephaven/web-client-ui@4441109)), closes [#1359](deephaven/web-client-ui#1359)
* data bar render from API ([#1415](deephaven/web-client-ui#1415)) ([ee7d1c1](deephaven/web-client-ui@ee7d1c1)), closes [#0000](https://github.com/deephaven/web-client-ui/issues/0000) [#FF0000](https://github.com/deephaven/web-client-ui/issues/FF0000) [#FFFF00](https://github.com/deephaven/web-client-ui/issues/FFFF00) [#FFFF00](https://github.com/deephaven/web-client-ui/issues/FFFF00) [#00FF00](https://github.com/deephaven/web-client-ui/issues/00FF00)
* Monaco theming ([#1560](deephaven/web-client-ui#1560)) ([4eda17c](deephaven/web-client-ui@4eda17c)), closes [#1542](deephaven/web-client-ui#1542)
* Theme Plugin Loading ([#1524](deephaven/web-client-ui#1524)) ([a9541b1](deephaven/web-client-ui@a9541b1)), closes [#1a171](https://github.com/deephaven/web-client-ui/issues/1a171) [#4c7](https://github.com/deephaven/web-client-ui/issues/4c7) [#1a171](https://github.com/deephaven/web-client-ui/issues/1a171) [#4c7](https://github.com/deephaven/web-client-ui/issues/4c7) [#4c7](https://github.com/deephaven/web-client-ui/issues/4c7) [#1530](deephaven/web-client-ui#1530)


### BREAKING CHANGES

* Theme variables have to be present on body to avoid
Monaco init failing
* Inline LoadingSpinner instances will need to be
decorated with `className="loading-spinner-vertical-align"` for vertical
alignment to work as before

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023_noMilestone bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

4 participants