Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phantom barrage rows #2405

Closed
devinrsmith opened this issue May 18, 2022 · 1 comment · Fixed by #2406
Closed

Phantom barrage rows #2405

devinrsmith opened this issue May 18, 2022 · 1 comment · Fixed by #2406
Assignees
@lbooker42
Labels
barrage bug Something isn't working
Milestone
May 2022

Comments

@devinrsmith
Copy link
Member

It looks like #2287 has introduced a bug into barrage. At a minimum, it causes streaming time tables to produce phantom rows in the web UI.

x = io.deephaven.engine.table.impl.TimeTable.newBuilder().period("00:00:01").streamTable(true).build()

Upon creation, the table occasionally ticks and produces a phantom row.

image

Upon re-viewporting, the data is initially "correct", but then phantom rows creep in.
@devinrsmith devinrsmith added bug Something isn't working barrage labels May 18, 2022
@devinrsmith devinrsmith added this to the May 2022 milestone May 18, 2022
@devinrsmith devinrsmith mentioned this issue May 18, 2022
Closed
@devinrsmith
Copy link
Member Author

I've verified this behavior does not happen in commit just prior.

@lbooker42 lbooker42 mentioned this issue May 19, 2022
Merged
nbauernfeind added a commit to nbauernfeind/deephaven-core that referenced this issue May 19, 2022
@nbauernfeind
Fix deephaven#2405
c141e98
nbauernfeind added a commit to nbauernfeind/deephaven-core that referenced this issue May 19, 2022
@nbauernfeind
Fix deephaven#2405
d500da8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbooker42 lbooker42

Labels
barrage bug Something isn't working
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Rewrite JS/GWT to use row counts (vs. row batches) lbooker42/deephaven-core
2 participants
@lbooker42 @devinrsmith