Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply consistent formatting for python files #3638

Open
devinrsmith opened this issue Mar 31, 2023 · 2 comments
Open

Apply consistent formatting for python files #3638

devinrsmith opened this issue Mar 31, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@devinrsmith
Copy link
Member

devinrsmith commented Mar 31, 2023

Just like we have automatic code formatting for .java files, it would be great to have the same for .python files.

Spotless has support for python files https://github.com/diffplug/spotless/tree/main/plugin-gradle#python.

The only current python format spotless currently implements is based around https://github.com/psf/black. That said, black seems like a great candidate as it seems like a very popular choice.

If it's not already, we probably would want to consider the exact same formatting applied to the docs repo.

@devinrsmith devinrsmith added this to the Backlog milestone Mar 31, 2023
@devinrsmith devinrsmith self-assigned this Mar 31, 2023
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Mar 31, 2023
devinrsmith added a commit to devinrsmith/deephaven-core that referenced this issue Mar 31, 2023
@devinrsmith
Copy link
Member Author

#5352 would be nice-to-have before this feature.

@devinrsmith
Copy link
Member Author

https://github.com/astral-sh/ruff has also been mentioned as black-compatible formatter / linter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant