-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected change with type hints not returning as specified type #4933
Comments
dsmmcken
added a commit
to deephaven/deephaven-plugins
that referenced
this issue
Dec 11, 2023
Better type hinting support means this was now actually triggering an error. However, it is currently returning numpy types, which is a bug in core. Initial random.seed(seed) now prints this error, and is expected to be fixed in next release. > DeprecationWarning: Seeding based on hashing is deprecated since Python 3.9 and will be removed in a subsequent version. The only supported seed types are: None, int, float, str, bytes, and bytearray. See: deephaven/deephaven-core#4933
dsmmcken
added a commit
to deephaven/deephaven-plugins
that referenced
this issue
Dec 11, 2023
Better type hinting support means this mistake was now actually triggering an error. Engine is currently returning numpy types instead of python types, which is a bug in core. Initial random.seed(seed) is printing this error because of the numpy.int64 type, but is expected to be fixed in the next dhc release. > DeprecationWarning: Seeding based on hashing is deprecated since Python 3.9 and will be removed in a subsequent version. The only supported seed types are: None, int, float, str, bytes, and bytearray. See: deephaven/deephaven-core#4933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I type hint as an
int
, I am unexpectedly getting back anumpy.int64
. If I don't type hint at all I get anint
.Note, same goes for float.
The text was updated successfully, but these errors were encountered: