Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance logs should contain the entire query string #5055

Open
chipkent opened this issue Jan 19, 2024 · 1 comment
Open

Performance logs should contain the entire query string #5055

chipkent opened this issue Jan 19, 2024 · 1 comment
Assignees
Labels
devrel-watch DevRel team is watching query engine
Milestone

Comments

@chipkent
Copy link
Member

Query logs contain shortened versions of query strings. This makes it very difficult to determine which lines are causing problems.

This is possibly related to #4918 .

Consider this example.

import deephaven.perfmon as pm

upl = pm.update_performance_log()
qopl = pm.query_operation_performance_log()
qpl = pm.query_performance_log()
pml = pm.process_metrics_log()
pil = pm.process_info_log()
ssl = pm.server_state_log()

from deephaven import empty_table, time_table

def fast(x:int) -> int:
    return int(x*(x+1)/2)

def slow(x:int) -> int:
    val = 0
    for i in range(x):
        val += i+1
    return val

from timeit import timeit
print(timeit(lambda : fast(100)))
print(timeit(lambda : slow(100)))

# Static table and query startup performance go to qopl table
t = empty_table(100).update_view(["A = ii"])
t2 = t.update(["X = fast(A)"])
t3 = t2.update(["Y = slow(A)"])

The updates are all showing up without formulas.

image
@chipkent chipkent added bug Something isn't working query engine triage devrel-watch DevRel team is watching labels Jan 19, 2024
@rcaudy rcaudy added this to the 5. Backlog milestone Jan 19, 2024
@rcaudy rcaudy self-assigned this Jan 19, 2024
@rcaudy rcaudy removed triage bug Something isn't working labels Jan 19, 2024
@rcaudy
Copy link
Member

rcaudy commented Jan 19, 2024

This is completely unrelated to #4918, and has been the "state of the art" since 2016 or earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devrel-watch DevRel team is watching query engine
Projects
None yet
Development

No branches or pull requests

3 participants