-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mitigate risks of OOM with SoftReference cache #5518
Comments
devinrsmith
added a commit
to devinrsmith/deephaven-core
that referenced
this issue
May 23, 2024
devinrsmith
added a commit
that referenced
this issue
May 23, 2024
devinrsmith
added a commit
that referenced
this issue
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A deep dive into #5516 exposed a situation where the JVM was getting OOM errors while there was plenty of reclaimable heap (99.9% of heap was taken up by reclaimable SoftReference'd objects). That fix itself should greatly reduce the risk of this error in this exact situation, but fundamentally other code paths can still hit JNI critical sections and cause "Retried waiting for GCLocker too often allocating" and OOMs. See https://github.com/devinrsmith/GCLockerTooOftenAllocating for a more detailed reproduction.
In the meantime, we can mitigate the risks by increasing
-XX:GCLockerRetryAllocationCount
above the default of 2.The text was updated successfully, but these errors were encountered: