Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch releases of jsapi-types getting dist-tag latest incorrectly #5572

Open
mofojed opened this issue Jun 5, 2024 · 3 comments
Open

Patch releases of jsapi-types getting dist-tag latest incorrectly #5572

mofojed opened this issue Jun 5, 2024 · 3 comments
Labels
bug Something isn't working triage

Comments

@mofojed
Copy link
Member

mofojed commented Jun 5, 2024

Description

When we publish a patch version of deephaven-core (and subsequently a patch version of the @deephaven/jsapi-types package), it should not be labelled as latest.
For example, we previously published v0.34.3, which is the latest version. We then went back and released a patch to v0.33, and published v0.33.4. That should not have the dist-tag of latest, latest should still point to v0.34.3.
For web-client-ui packages, we set the dist tag to just the major version number of the release branch that is being patched, e.g. https://github.com/deephaven/web-client-ui/blob/37571633dd0be5b7a606bee45af10f6a7d09d4ec/lerna.json#L6

See screenshot below. v0.34.3 was published 13 days ago, and then we published a patch 0.33.4 yesterday, but that stole the latest tag.

Additional details and attachments
image

@mofojed
Copy link
Member Author

mofojed commented Jun 7, 2024

Fix would just be changing latest to the release branch name at

run: npm publish --provenance --tag latest web/client-api/types/build/deephaven-jsapi-types-*.tgz
(e.g. v0.33)

mofojed added a commit to mofojed/deephaven-core that referenced this issue Jun 17, 2024
- Should no longer clobber the `latest` tag
- Fixes deephaven#5572
mofojed added a commit to mofojed/deephaven-core that referenced this issue Jun 18, 2024
- Should no longer clobber the `latest` tag
- Fixes deephaven#5572
devinrsmith pushed a commit that referenced this issue Jun 18, 2024
- Should no longer clobber the `latest` tag
- `rc/v0.33.x` workaround for #5572
mofojed added a commit to mofojed/deephaven-core that referenced this issue Jul 18, 2024
- Should no longer clobber the `latest` tag
- `rc/v0.35.x` workaround for deephaven#5572
mofojed added a commit to mofojed/deephaven-core that referenced this issue Jul 18, 2024
- Should no longer clobber the `latest` tag
- `rc/v0.35.x` workaround for deephaven#5572
@mofojed
Copy link
Member Author

mofojed commented Jul 18, 2024

From @devinrsmith :

May need to be a bash script. You'll want to get the official version from gradle (as opposed to the branch name)

@devinrsmith
Copy link
Member

devinrsmith commented Jul 18, 2024

There are a couple of GH tasks that call the outputVersion task and get the version:

      - name: All Javadoc
        uses: burrunan/gradle-cache-action@v1
        with:
          job-id: allJavadoc
          arguments: --scan outputVersion combined-javadoc:allJavadoc
          gradle-version: wrapper
          
      - name: Get Deephaven Version
        id: dhc-version
        run: echo "version=$(cat build/version)" >> $GITHUB_OUTPUT

which can then be referenced via ${{ steps.dhc-version.outputs.version }}

devinrsmith pushed a commit that referenced this issue Jul 18, 2024
- Should no longer clobber the `latest` tag
- `rc/v0.35.x` workaround for #5572
niloc132 pushed a commit to niloc132/deephaven-core that referenced this issue Nov 21, 2024
- Should no longer clobber the `latest` tag
- `rc/v0.33.x` workaround for deephaven#5572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

2 participants