-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka JSON Spec Does Propagates DH Nulls Instead of JSON Null #5701
Labels
bug
Something isn't working
core
Core development tasks
json
kafka
kafka-exhaust
release blocker
A bug/behavior that puts is below the "good enough" threshold to release.
Milestone
Comments
nbauernfeind
added
bug
Something isn't working
core
Core development tasks
kafka
release blocker
A bug/behavior that puts is below the "good enough" threshold to release.
kafka-exhaust
json
labels
Jun 30, 2024
devinrsmith
added a commit
to devinrsmith/deephaven-core
that referenced
this issue
Jul 1, 2024
This fixes what was likely a copy-paste error, where the Kafka JSON producing logic checked for NULL_SHORT for int fields. None of the other field types were mishandled. It's worth noting that the json producer will omit null fields by default, and to explicitly output a JSON null (`{..., "myIntField": null, ...}`), the `boolean outputNulls` must be set to `true` (exposed as `output_nulls` in python). Fixes deephaven#5701
devinrsmith
added a commit
to devinrsmith/deephaven-core
that referenced
this issue
Jul 18, 2024
This fixes what was likely a copy-paste error, where the Kafka JSON producing logic checked for `NULL_SHORT` for int fields. None of the other field types were mishandled. It's worth noting that the json producer will omit null fields by default, and to explicitly output a JSON null (`{..., "myIntField": null, ...}`), the `boolean outputNulls` must be set to `true` (exposed as `output_nulls` in python). Fixes deephaven#5701
devinrsmith
added a commit
that referenced
this issue
Jul 18, 2024
This fixes what was likely a copy-paste error, where the Kafka JSON producing logic checked for `NULL_SHORT` for int fields. None of the other field types were mishandled. It's worth noting that the json producer will omit null fields by default, and to explicitly output a JSON null (`{..., "myIntField": null, ...}`), the `boolean outputNulls` must be set to `true` (exposed as `output_nulls` in python). Fixes #5701 Cherry-pick of #5702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
core
Core development tasks
json
kafka
kafka-exhaust
release blocker
A bug/behavior that puts is below the "good enough" threshold to release.
To reproduce:
This produces deephaven null values to the stream instead of real null values; see redpanda snapshot below:
(You will have to ignore that X == "3", Y == non-null instance in my image; that was because I [accidentally] had more than one producer running on the same topic at the time of the shot.)
The text was updated successfully, but these errors were encountered: