Simplify server startup and dagger usage #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
previously approved these changes
Nov 23, 2021
nbauernfeind
previously approved these changes
Nov 23, 2021
grpc-api/src/main/java/io/deephaven/grpc_api/runner/DeephavenApiServer.java
Outdated
Show resolved
Hide resolved
This is a first step towards making the http server for grpc replacable with Jetty. Partial deephaven#1270
niloc132
dismissed stale reviews from nbauernfeind and devinrsmith
via
35b2dd1
niloc132
force-pushed
the
1270-dagger-simplify
branch
from
35a48e7 to
35b2dd1
Compare
nbauernfeind
approved these changes
Nov 23, 2021
niloc132
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards making the http server for grpc
replacable with Jetty.
Partial #1270