Refactored away TableTools module, fixes #1553 #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmao-denver
commented
Dec 3, 2021
jmao-denver
commented
- split TableTools functionality into table_factory.py, dtypes.py, column.py, table.py
- added docstrings
- added test cases
jmao-denver
requested review from
chipkent,
devinrsmith,
jakemulf and
jjbrosnan
Changed to use empty_table instead of time_table to avoid a lock issue
using subTest will make test failures easier to identify in group tests
The poorly named variable is the result of the recent db module refactoring project that renamed/moved the corresponing java class to a differnt package.
Decided against support Table diff() method for now due to the confusing max_diff param.
chipkent
requested changes
Dec 13, 2021
1. beefed up the tests 2. bug fixes 3. cleaned up pydoc
chipkent
requested changes
Dec 21, 2021
and expanded the unit test to cover them all
1. added classmethod from_jtype in DType to support reverse lookup 2. fixed a bug in building a table's column defs 3. minor fixes in boostrap.py to make it work in the new project structure 4. added a testcase to verify Column's component_type set correctly for array type columns
1. Added a 'remap' parameter to the method to allow the users to provide a callable for mapping special DH values such as NULL_LONG etc. 2. With the abstraction introduced by the above chagne, there is no need to create type specific concrete mapping capability ourselves and that leads to the removal of sub types of DType 3. However, CharDType is kept to make the conversion from Python str to Java char array easier for the users with the default remap callable set to Python built-in ord
tested the case of downcast from double to float generating inf
chipkent
requested changes
Jan 4, 2022
one minor change in the docstring and some improvments to test_dtypes
chipkent
approved these changes
Jan 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.