Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBTimeZone renamed to TimeZone #1660

Merged
merged 1 commit into from
Dec 8, 2021
Merged

DBTimeZone renamed to TimeZone #1660

merged 1 commit into from
Dec 8, 2021

Conversation

chipkent
Copy link
Member

@chipkent chipkent commented Dec 8, 2021

DBTimeZone renamed to TimeZone

Resolves #1659

@chipkent chipkent added this to the Nov 2021 milestone Dec 8, 2021
@chipkent chipkent self-assigned this Dec 8, 2021
jmao-denver
jmao-denver approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a global search of DBTimeZone myself and found that the changes in the PR correctly renamed all of them when appropriate.

@chipkent chipkent merged commit 5e17bed into deephaven:main Dec 8, 2021
@chipkent chipkent deleted the 1659_rename_dbtimezone branch December 8, 2021 21:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmao-denver jmao-denver jmao-denver approved these changes

@jakemulf jakemulf jakemulf approved these changes

Assignees

@chipkent chipkent

Labels
DocumentationNeeded python python-server-side
Projects
None yet
Milestone
Nov 2021
Development

Successfully merging this pull request may close these issues.

DBTimeZone needs to be renamed to TimeZone
3 participants
@chipkent @jmao-denver @jakemulf