Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deephaven-csv #1920

Merged
merged 8 commits into from
Feb 8, 2022
Merged

Conversation

devinrsmith
Copy link
Member

No description provided.

@devinrsmith devinrsmith added this to the Feb 2022 milestone Feb 2, 2022
@devinrsmith devinrsmith self-assigned this Feb 2, 2022
@devinrsmith devinrsmith requested a review from kosak February 2, 2022 00:03
kosak
kosak previously approved these changes Feb 2, 2022
Copy link
Contributor

@kosak kosak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

I guess I should remind you to not check in the "sonatype.org" thing, and I guess also the official csv release won't be named -SNAPSHOT in build.gradle

@devinrsmith devinrsmith marked this pull request as ready for review February 8, 2022 19:07
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinrsmith devinrsmith merged commit 1821024 into deephaven:main Feb 8, 2022
@devinrsmith devinrsmith deleted the use-deephaven-csv branch February 8, 2022 21:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants