Nightly builds to run on both Java11 and 17 #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
requested review from
devinrsmith,
jcferretti,
JamesXNelson and
mofojed
as code owners
devinrsmith
requested changes
Mar 8, 2022
devinrsmith
approved these changes
Mar 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is the result of the bug hunt around c2 compilation issues, and while it adds support for building each night on each Java 11 and 17, it also simplifies the nightly build yml to run each expected task using the matrix strategy instead of repeating sections of the build over and over.
Build output such as test reports are also somewhat consolidated, to reduce the number of zips available for download, and contain related material in the same file.
One potential downside is that the "Publish Test Results" is now once per matrix run rather than collecting results across all runs.
Another potential downside (or upside) is that when one task fails, the others don't continue. This could also be an upside, save some build minutes, as these are not short tasks. This is configurable, I just set the default for now.