Pyclient groovy support #2107
Merged
Pyclient groovy support #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
previously approved these changes
Mar 21, 2022
devinrsmith
reviewed
Mar 21, 2022
pyclient/pydeephaven/session.py
Outdated
| @@ -67,6 +68,7 @@ def __init__(self, host: str = None, port: int = None, never_timeout: bool = Tru | |||
| self._tables = {} | |||
| self._never_timeout = never_timeout | |||
| self._keep_alive_timer = None | |||
| self.session_type = session_type | |||
There was a problem hiding this comment.
Should we try to stick to an underscore for internal variables coding convention?
There was a problem hiding this comment.
Yeah that's fine, updated
devinrsmith
approved these changes
Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unblocks deephaven/action-assert-dh-tables-present#3 and other similar issues with trying to use the pyclient with a groovy deephaven instance