Clean up tables correctly. #2132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
force-pushed
the
kafka-memory-leak
branch
from
0342109 to
43f0306
Compare
|
I'm not confident there aren't other bugs in the ApplicationServiceGrpcImpl. There are bifurcated paths out of schedulePropagationOrClearIncrementalState, and they don't seem to be equivalent. The job side seems to be missing out on clearing out knownFieldMap; and the other side seems to be missing out on maybeUnmanage. I've just added an extra remove for knownFieldMap, but there may need to be deeper look into liveness for both paths to ensure equivalent. (@nbauernfeind) |
|
On another note, it seems like we need two full GCs to actually clear out Kafka tables. |
devinrsmith
force-pushed
the
kafka-memory-leak
branch
from
43f0306 to
6c9527f
Compare
|
Superseded by #2158 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2130
Co-authored-by: Ryan Caudy ryan@deephaven.io