Bump deephaven-csv to 0.3.0 #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
commented
Mar 30, 2022
| for (int ii = 0; ii < columnNames.length; ++ii) { | ||
| final String columnName = columnNames[ii]; | ||
| final MySinkBase<?, ?> sink = (MySinkBase<?, ?>) sinks[ii]; | ||
| maxSize = Math.max(maxSize, sink.resultSize()); |
There was a problem hiding this comment.
Is there any reason why tracking maxSize by each sink is different than result.numRows()?
There was a problem hiding this comment.
No, I was probably confused at the time of writing that code.
kosak
approved these changes
Mar 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2133