Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating a Java array when we can simply use the existing instance #3448

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Avoid creating a Java array when we can simply use the existing instance #3448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...api/src/main/java/io/deephaven/web/client/api/subscription/TableViewportSubscription.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public TableViewportSubscription(double firstRow, double lastRow, Column[] colum
batcher.setFlat(true);
});
// TODO handle updateInterval core#188
Column[] columnsToSub = table.isStreamTable() ? table.getColumns().asArray(new Column[0]) : columns;
Column[] columnsToSub = table.isStreamTable() ? Js.uncheckedCast(table.getColumns()) : columns;
table.setInternalViewport(firstRow, lastRow, columnsToSub);

// Listen for events and refire them on ourselves, optionally on the original table
Expand Down