Fix autocomplete suggestions overwriting existing text #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
approved these changes
Feb 21, 2023
devinrsmith
approved these changes
Feb 21, 2023
mofojed
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3363
TextEdit.rangeshould be the range of characters to be replaced, not the range of the inserted characters. For completions that should just be the original rangeWe should maybe change our returned
TextEditto usenewTextinstead oftextto match the LSP spec. That would require a 1 line change in the web UI, and it probably needs to support both options since the monaco component is re-used in enterprise