Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS API should only show non-constituent columns in groupedColumns array #3482

Merged
merged 1 commit into from
Mar 3, 2023
Merged

JS API should only show non-constituent columns in groupedColumns array #3482

merged 1 commit into from
Mar 3, 2023

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Mar 3, 2023

Fixes #3477

@niloc132 niloc132 added this to the Feb 2023 milestone Mar 3, 2023
@niloc132 niloc132 requested a review from bmingles March 3, 2023 19:48
bmingles
bmingles approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the extra rows are no longer present in groupedColumns. UI behaves as expected on rollup now.

@niloc132 niloc132 merged commit b7e72c9 into deephaven:main Mar 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmingles bmingles bmingles approved these changes

Assignees
No one assigned
Labels
jsapi NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed rollup
Projects
None yet
Milestone
Feb 2023
Development

Successfully merging this pull request may close these issues.

Rollup rows produces duplicates in groupedColumns array
2 participants
@niloc132 @bmingles