Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the explicit versioning of dependencies for the Python client for both testing and deployment #3495

Merged
merged 2 commits into from
Mar 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions py/client/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -86,17 +86,21 @@ tasks.getByName('check').dependsOn(Docker.registerDockerTask(project, 'testPyCli
from('tests') {
into 'project/tests'
}
from ('requirements-dev.txt') {
into 'project/'
}
}
containerDependencies.dependsOn = [deephavenDocker.healthyTask]
containerDependencies.finalizedBy = deephavenDocker.endTask
network = deephavenDocker.networkName.get()
dockerfile {
from('deephaven/python:local-build')
runCommand '''set -eux; \\
pip3 install unittest-xml-reporting==3.0.4 pyarrow==7.0.0 protobuf==3.20.1 grpcio==1.46.0 bitstring==3.1.9 pandas==1.2.5 timeout-decorator==0.5.0;\\
mkdir -p /out/report'''
copyFile('project', '/project')
workingDir('/project')
runCommand '''set -eux; \\
mkdir -p /out/report; \\
pip3 install --upgrade pip; \\
pip3 install -r requirements-dev.txt'''
environmentVariable 'DH_HOST', deephavenDocker.containerName.get()
environmentVariable 'DH_PORT', '8080'
}
Expand Down
10 changes: 10 additions & 0 deletions py/client/requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
pandas
pyarrow
grpcio
setuptools
protobuf
wheel
sphinx
bitstring
unittest-xml-reporting
timeout-decorator
13 changes: 4 additions & 9 deletions py/client/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
pandas~=1.2.5
pyarrow~=6.0.1
grpcio~=1.46.3
setuptools~=47.1.0
protobuf~=3.20.0
wheel
sphinx
bitstring~=3.1.7
timeout-decorator~=0.5.0
pyarrow
grpcio
protobuf
bitstring