Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in EMA tests #3572

Merged
merged 2 commits into from
Mar 19, 2023
Merged

Fix a bug in EMA tests #3572

merged 2 commits into from
Mar 19, 2023

Conversation

jmao-denver
Copy link
Contributor

@jmao-denver jmao-denver commented Mar 19, 2023 •
edited
Loading

Not sure how it happened - the flip of the 'if' branches, could be a mistake caused by distraction.

@jmao-denver jmao-denver added this to the Mar 2023 milestone Mar 19, 2023
@jmao-denver jmao-denver self-assigned this Mar 19, 2023
rcaudy
rcaudy reviewed Mar 19, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. rt should never be bigger than t. I think you should just take the shared lock and assert that they're equal.

@jmao-denver jmao-denver merged commit b5c2d6c into deephaven:main Mar 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2023
@jmao-denver jmao-denver deleted the 3571-pyclient-ema-tests-nightly branch March 31, 2023 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

Assignees

@jmao-denver jmao-denver

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
Mar 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@jmao-denver @rcaudy