Provide reconnect wiring for other JS API types #3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
jsapi
NoDocumentationNeeded
NoReleaseNotesNeeded
mofojed
requested changes
Mar 31, 2023
web/client-api/src/main/java/io/deephaven/web/client/api/lifecycle/HasLifecycle.java
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/widget/plot/JsFigure.java
Show resolved
Hide resolved
web/client-api/src/main/java/io/deephaven/web/client/api/lifecycle/HasLifecycle.java
Outdated
Show resolved
Hide resolved
mofojed
approved these changes
Mar 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by creating a rollup, a plot with a table, and a plot with a partitioned table (i.e. "plot by"), taking the browser offline for up to a minute, and then going online again, and confirming that all widgets correctly connected and resumed ticking. Note that the current version of web-client-ui will make the page unusable if the old "HACK_CONNECTION_FAILURE" event is emitted - either test with a newer web UI or disable that event.
Fixes #3616