Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify Use of Java NIO for extensions-arrow #3637

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Specify Use of Java NIO for extensions-arrow #3637

merged 1 commit into from
Mar 31, 2023

Conversation

nbauernfeind
Copy link
Member

@nbauernfeind nbauernfeind commented Mar 31, 2023 •
edited
Loading

Fixes java17/java18 issue not being able to initialize arrow memory utils. The issue was introduced in #3420.

@nbauernfeind nbauernfeind added bug Something isn't working build NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Mar 31, 2023
@nbauernfeind nbauernfeind added this to the Mar 2023 milestone Mar 31, 2023
@nbauernfeind nbauernfeind self-assigned this Mar 31, 2023
devinrsmith
devinrsmith approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@devinrsmith devinrsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you have verified this locally (both, the tests do fail without it, and are fixed with it).

Probably worthwhile to add a reference and commit message to the PR # where this issue was introduced.

@nbauernfeind
Copy link
Member Author

Yes, tested that ./gradlew extensions-arrow:test -PtestRuntimeVersion=17 fails without the change and passes with it.

@nbauernfeind nbauernfeind merged commit 581d377 into deephaven:main Mar 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinrsmith devinrsmith devinrsmith approved these changes

Assignees

@nbauernfeind nbauernfeind

Labels
bug Something isn't working build NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed.
Projects
None yet
Milestone
Mar 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@nbauernfeind @devinrsmith