Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve query library performance by using vector iteration #3659

Merged
merged 25 commits into from
Apr 6, 2023

Conversation

chipkent
Copy link
Member

@chipkent chipkent commented Apr 4, 2023

Performance of the query library has been improved by moving from direct access to iteration.

Resolves #3574

@chipkent chipkent added this to the Apr 2023 milestone Apr 4, 2023
@chipkent chipkent requested a review from kosak as a code owner April 4, 2023 19:37
@chipkent chipkent self-assigned this Apr 4, 2023
@chipkent chipkent requested a review from rcaudy as a code owner April 4, 2023 19:37
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stopping early, because we need to do more work for the primitive cases.

engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Basic.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Numeric.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Numeric.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Numeric.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Numeric.ftl Outdated Show resolved Hide resolved
engine/function/src/templates/Numeric.ftl Show resolved Hide resolved
Removing unneeded method.
Removing unneeded methods and making boolean methods more efficient.
Adding try-with blocks
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm caught up. Once we merge my PR to this PR, I think we can merge (or ask Corey to review for extra safety).

Improve Vector.toArray copy safety, and clean up Boolean method templates
@rcaudy rcaudy merged commit a8a029f into deephaven:main Apr 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update function libraries to use iteration with Vectors
2 participants