-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore totals table support in the JS API #3662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niloc132 At a quick glance, how would @emilyhuxng use this for the databar stuff? We can create a totals table, but we can't join it back to the original table. JsTable.join
expects another JsTable
, whereas this is a JsTotalsTable
. Or am I misthinking this?
Good call, I'll work on relaxing that a bit further. Under the hood, a TotalsTable is just a Table, except we don't let you perform certain operations on it that don't make sense. |
@emilyhuxng I've added a new interface which will will permit tables and totals tables to be joined to tables and totals tables. |
c6755db
to
808bf79
Compare
808bf79
to
12e61ab
Compare
@mofojed this isn't quite ready, but I wanted to discuss two things, see if we can find a way to finalize and ship it:
|
Discussed with Ryan, and we could paper over both of these with custom columns (updateview to normalize arrays to string, and rename Count columns to ColA__Count, ColB__Count...), but ideally we wouldnt do too much of this if we can help it. |
For the second, I'd prefer custom columns to match DHE behaviour, until we've improved the JS API usage of subscriptions. |
In column statistics, the Count operation is only non-nulls (as distinct from Size), but not in aggregations (in either dhe or dhc). |
ba1112e
to
1130bad
Compare
Column renaming and toString-ing is complete, plus also removing requested aggregations that don't make sense and the server will reject. |
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/2720 |
Fixes #3314