Added Exponential Moving Sum to UpdateBy operators
#3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
reviewed
Apr 5, 2023
table-api/src/main/java/io/deephaven/api/updateby/UpdateByOperation.java
Outdated
Show resolved
Hide resolved
java-client/session/src/main/java/io/deephaven/client/impl/UpdateByBuilder.java
Outdated
Show resolved
Hide resolved
java-client/session/src/test/java/io/deephaven/client/impl/UpdateBySpecBuilderTest.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/DoubleEMSOperator.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BasePrimitiveEMSOperator.java
Outdated
Show resolved
Hide resolved
|
Mentioned in DM, but there may be a way to share operator implementations among Exponential Moving Avg / Sum / Min / Max. There also may be ways to share construction of them to make it easier for end user? For example, it might be cool to have specifically typed helpers off of existing specs: avg().exponential(window(...))
sum_().exponential(window(...))
avg().rolling(window(...))
... |
|
Creating a shared Exponential Moving implementations is clever and I will refactor in a follow-on PR (likely |
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/UpdateByOperatorFactory.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BaseBigNumberEMSOperator.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BaseBigNumberEMSOperator.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BasePrimitiveEMSOperator.java
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BigDecimalEMSOperator.java
Outdated
Show resolved
Hide resolved
...table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/BigIntegerEMSOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/CharEMSOperator.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/CharEMSOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/FloatEMSOperator.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/updateby/emsum/FloatEMSOperator.java
Outdated
Show resolved
Hide resolved
devinrsmith
approved these changes
Apr 12, 2023
nbauernfeind
approved these changes
Apr 17, 2023
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/2452 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2760