Check if DH Enterprise Python API is installed by mistake and if so produce a helpful message #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
added
NoDocumentationNeeded
python-server-side
NoReleaseNotesNeeded
devinrsmith
reviewed
Apr 10, 2023
engine/table/src/main/java/io/deephaven/engine/util/jpy/JpyInit.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/util/jpy/JpyInit.java
Outdated
Show resolved
Hide resolved
jcferretti
reviewed
Apr 10, 2023
There was a problem hiding this comment.
I discussed with JIanfeng potential DnD impact, I think there isn't any risk here, and any gotchas that we may have missed would be weeded out in the smoke testing when the next DHC release is out and DHE "takes" it for DnD in some particular DHE version. At that point we do smoke testing, we try to create a DnD worker and subscribe to a barrage table in a DnD worker from a Enterprise legacy worker.
chipkent
requested changes
Apr 10, 2023
engine/table/src/main/java/io/deephaven/engine/util/jpy/JpyInit.java
Outdated
Show resolved
Hide resolved
jmao-denver
changed the title
devinrsmith
previously approved these changes
Apr 11, 2023
engine/table/src/main/java/io/deephaven/engine/util/jpy/JpyInit.java
Outdated
Show resolved
Hide resolved
chipkent
previously approved these changes
Apr 12, 2023
engine/table/src/main/java/io/deephaven/engine/util/jpy/JpyInit.java
Outdated
Show resolved
Hide resolved
chipkent
approved these changes
Apr 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3553