Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port DH-11185: Parallel Where #3679

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Port DH-11185: Parallel Where #3679

merged 2 commits into from
Apr 24, 2023

Conversation

nbauernfeind
Copy link
Member

@nbauernfeind nbauernfeind commented Apr 11, 2023 •
edited
Loading

@nbauernfeind nbauernfeind added this to the Apr 2023 milestone Apr 11, 2023
@nbauernfeind nbauernfeind self-assigned this Apr 11, 2023
@nbauernfeind nbauernfeind mentioned this pull request Apr 11, 2023
Open
lbooker42
lbooker42 previously approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@lbooker42 lbooker42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, very minor quibbles over naming and a single question.

engine/table/src/main/java/io/deephaven/engine/table/impl/AbstractFilterExecution.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/InitialFilterExecution.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/WhereListener.java Outdated Show resolved Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/QueryTableWhereTest.java Outdated Show resolved Hide resolved
@nbauernfeind nbauernfeind enabled auto-merge (squash) April 24, 2023 15:44
@nbauernfeind nbauernfeind merged commit 823f0e8 into deephaven:main Apr 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbooker42 lbooker42 lbooker42 approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy

@cpwright cpwright Awaiting requested review from cpwright

Assignees

@nbauernfeind nbauernfeind

Labels
NoDocumentationNeeded port query engine ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
Apr 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@nbauernfeind @lbooker42