Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RollingCount feature to UpdateBy #3683

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Add RollingCount feature to UpdateBy #3683

merged 3 commits into from
Apr 18, 2023

Conversation

lbooker42
Copy link
Contributor

No description provided.

@lbooker42 lbooker42 added this to the Apr 2023 milestone Apr 11, 2023
@lbooker42 lbooker42 self-assigned this Apr 11, 2023
@nbauernfeind nbauernfeind self-requested a review April 17, 2023 17:44
nbauernfeind
nbauernfeind reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@nbauernfeind nbauernfeind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious if you should prefer storing all of the values into a RollingByteBuffer and just store a 0 if null and 1 if non-null (or NULL_BYTE isn't terrible if only slightly confusing).

For this particular operator, should we support Object columns? BigDecimal and BigInteger would not need impls if we supported Object.

@lbooker42
Copy link
Contributor Author

Great comments, have adopted your suggestions and use ByteRingBuffer for value storage and created Object operator.

@lbooker42 lbooker42 merged commit 4cbbc70 into deephaven:main Apr 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2023
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

How-to: https://github.com/deephaven/deephaven.io/issues/2472
Conceptual: https://github.com/deephaven/deephaven.io/issues/2471
Reference: https://github.com/deephaven/deephaven.io/issues/2469
Blog: https://github.com/deephaven/deephaven.io/issues/2470

@lbooker42 lbooker42 deleted the lab-rollingcount branch June 26, 2024 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nbauernfeind nbauernfeind nbauernfeind approved these changes

Assignees

@lbooker42 lbooker42

Labels
DocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
Apr 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@lbooker42 @deephaven-internal @nbauernfeind